adriangb commented on PR #13795: URL: https://github.com/apache/datafusion/pull/13795#issuecomment-2552933620
> The only change is for the case where row_count = null_count is null and the predicate is true: previously true would be returned but now null is returned. Since we interpret null as true the end result is the same. If we wanted to eliminate this change from this PR we can add a condition `and row_count is not null and null_count is not null`. If we go one small step further and add `and col_a_min is not null and col_b_min is not null` then we actually ensure that the predicates always return `true` or `false` and never `null` which IMO would be helpful just to minimize confusion especially since the interpretation of `null` here is so confusing and opposes the interpretation of `null` in a `where` clause. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
