adriangb commented on PR #13795: URL: https://github.com/apache/datafusion/pull/13795#issuecomment-2552902686
In case there is any appetite for it, I found that you can make the predicates always evaluate to `true` or `false` (never `null`) by tacking on a `OR col_a_min IS NULL OR col_a_max IS NULL OR col_a_row_count IS NULL OR col_a_null_count IS NULL` and so on. I think this would be a nice further improvement to make it easier to reason about the logic the predicates return and would be a safee change to make for anyone depending on this code. We already track all referenced columns in `RequiredColumns` 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
