alamb commented on code in PR #13663:
URL: https://github.com/apache/datafusion/pull/13663#discussion_r1894552648
##########
datafusion/common/src/config.rs:
##########
@@ -459,10 +459,6 @@ config_namespace! {
/// default parquet writer setting
pub statistics_enabled: Option<String>, transform = str::to_lowercase,
default = Some("page".into())
- /// (writing) Sets max statistics size for any column. If NULL, uses
- /// default parquet writer setting
- pub max_statistics_size: Option<usize>, default = Some(4096)
Review Comment:
I think simply removing the config option is pretty rough as you end up with
errors liek this
> External error: query failed: DataFusion error: Invalid or Unsupported
Configuration: Config value "max_statistics_size" not found on ParquetOptions
The best thing to do would be to mark the config setting deprecated, but
there wasn't an obvious way to do this with the existing macros. I will futz
with the macros and see if I can make it deprecated somehow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
