alamb commented on code in PR #13663:
URL: https://github.com/apache/datafusion/pull/13663#discussion_r1894552755
##########
datafusion/proto-common/src/from_proto/mod.rs:
##########
@@ -321,6 +321,8 @@ impl TryFrom<&protobuf::Field> for Field {
fn try_from(field: &protobuf::Field) -> Result<Self, Self::Error> {
let datatype = field.arrow_type.as_deref().required("arrow_type")?;
let field = if field.dict_id != 0 {
+ // TODO file a ticket about handling deprecated dict_id attributes
Review Comment:
Need to update per https://github.com/apache/arrow-rs/pull/6885 I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
