jkosh44 commented on PR #14289: URL: https://github.com/apache/datafusion/pull/14289#issuecomment-2614003106
> Maybe we need yet another trait implementation One complication with this approach is that we might end up skipping over error checks that are inside of the function implementation. For example, https://github.com/apache/datafusion/blob/18f14abf3fcef11f014f42e1f0cb8cdc35f257a3/datafusion/functions-nested/src/extract.rs#L437. So instead of `SELECT array_slice(1.5, NULL, NULL)` returning an error for an unsupported type in the first argument, it will return `NULL`. The DuckDB behavior is to return an error here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
