jkosh44 commented on code in PR #14289:
URL: https://github.com/apache/datafusion/pull/14289#discussion_r1929903548
##########
datafusion/functions-nested/src/extract.rs:
##########
@@ -330,7 +330,8 @@ pub(super) struct ArraySlice {
impl ArraySlice {
pub fn new() -> Self {
Self {
- signature: Signature::variadic_any(Volatility::Immutable),
+ // TODO: This signature should use the actual accepted types, not
variadic_any.
Review Comment:
Another approach, which probably warrants it's own issue/PR, is to add
something similar to PostgreSQL psuedo-types
(https://www.postgresql.org/docs/current/datatype-pseudo.html). Then I can make
a signature of something like
```Rust
TypeSignature::OneOf(vec![
TypeSignature::Exact(vec![AnyArray, Int64, Int64]),
TypeSignature::Exact(vec![AnyArray, Int64, Int64, Int64]),
])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
