jkosh44 commented on PR #14289: URL: https://github.com/apache/datafusion/pull/14289#issuecomment-2614165389
> This is because the signature for extract doesn't handle type checking correctly, it uses variadic_any, not because of the introduced new trait method Oh, great then I don't think my concern is actually valid. > I prefer to has Strict mode by default -- returns nulls if the arguments contains nulls. > > We can add field handle_nulls: bool to Signature, false by default, the user can easily change to true and handle nulls by themselves. I pushed a PoC for an implementation using `strict` in the Signature. I had called it strict and made the default the opposite of what you suggested because I implemented it before I saw your comment. My thought process for the opposite default was that it would be more backwards compatible, otherwise we'd have to check every function that really does not want to be strict. I can easily change it to the reverse though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
