jkosh44 commented on PR #14289:
URL: https://github.com/apache/datafusion/pull/14289#issuecomment-2620139202
> I don't like the name strict as it can mean different things (like fail on
parsing invalid strings), I think it should be an enum on null handling
How about something like
```Rust
/// How a function handles Null input.
enum NullHandling {
/// Pass Null inputs into the function implementation.
PassThrough,
/// Any Null input causes the function to return Null.
Propogate,
}
```
? I'm happy to hear any bike shedding on the names because I'm not really
familiar with the project's existing style.
> I prefer to has Strict mode by default -- returns nulls if the arguments
contains nulls.
I've been thinking about this some more, and I'm more convinced that the we
should set the default to not strict or `NullHandling::PassThrough`. Otherwise,
not only would the behavior of all of our functions silently change, but the
behavior of all user's UDFs would also change. So setting it to strict by
default feels like too big of a breaking change. Though, this is my first PR
and I'm not super familiar with the Project's backwards compatibility
guarantees, so I'll default to a reviewer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
