eliaperantoni commented on PR #14439:
URL: https://github.com/apache/datafusion/pull/14439#issuecomment-2635144203
Thanks @comphead for your feedback. We appreciate it 🙏
> What comes to my mind is the PR might make the output too cumbersome
The actual error output doesn't change at all. i.e. if you get a
`DataFusionError` and you use any of the methods from `std::error::Error` it'll
still work the same way, exception made for the `X errors, first one is: {err}`
prefix for the `Display` implementation.
It only changes if you explicitly call `.iter`, which I think is a very
intentional act of extracting additional information from the error. But we
took care to not make it cumbersome by default and to not make breaking changes.
> extra attention to error can slow down the planning time
I think that's fair criticism. What could we do to solve this in a way that
doesn't complicate the code too much? I think it's also important to notice
that the performance impact occurs only when there are errors, and it would be
greater than without this PR only if the errors are more than 1. This is
because the only performance lost is due to the planner continuing after the
first error. In performance critical applications that run the same carefully
crafted queries, no extra code is executed and no extra allocations are made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
