alamb commented on PR #14439:
URL: https://github.com/apache/datafusion/pull/14439#issuecomment-2637539228
> Thanks @comphead for your feedback. We appreciate it 🙏
>
> > What comes to my mind is the PR might make the output too cumbersome
>
> The actual error output doesn't change at all. i.e. if you get a
`DataFusionError` and you use any of the methods from `std::error::Error` it'll
still work the same way, exception made for the `X errors, first one is: {err}`
prefix for the `Display` implementation.
Yeah, I think this makes sense -- by default show the first error message
unless the application wants to show more of them
>
> It only changes if you explicitly call `.iter`, which I think is a very
intentional act of extracting additional information from the error. But we
took care to not make it cumbersome by default and to not make breaking changes.
>
> > extra attention to error can slow down the planning time
>
> I think that's fair criticism. What could we do to solve this in a way
that doesn't complicate the code too much? I think it's also important to
notice that the performance impact occurs only when there are errors, and it
would be greater than without this PR only if the errors are more than 1.
> some time back I think we already faced the issue that extra attention to
error can slow down the planning time.
This is an excellent point @comphead and I agree with @eliaperantoni 's
analysis that the additional overhead will happen when the query was going to
error anyways so I don't expect this to make a large difference
What we were seeing was that when planning created
`Err(DataFusionError::...)` during normal (non erroring queries) it was quite a
bit slower
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
