alamb commented on code in PR #14439:
URL: https://github.com/apache/datafusion/pull/14439#discussion_r1943247569
##########
datafusion/sqllogictest/src/engines/datafusion_engine/error.rs:
##########
@@ -30,7 +30,7 @@ pub enum DFSqlLogicTestError {
#[error("SqlLogicTest error(from sqllogictest-rs crate): {0}")]
SqlLogicTest(#[from] TestError),
/// Error from datafusion
- #[error("DataFusion error: {0}")]
+ #[error("DataFusion error: {}", .0.strip_backtrace())]
Review Comment:
I don't think we should add the backtrace to the errors in general
(definitely not in `slt`) as the backtraces would include line numbers / call
stacks that would change over time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
