findepi commented on code in PR #14483:
URL: https://github.com/apache/datafusion/pull/14483#discussion_r1942582463
##########
benchmarks/bench.sh:
##########
@@ -34,7 +34,7 @@ COMMAND=
BENCHMARK=all
DATAFUSION_DIR=${DATAFUSION_DIR:-$SCRIPT_DIR/..}
DATA_DIR=${DATA_DIR:-$SCRIPT_DIR/data}
-CARGO_COMMAND=${CARGO_COMMAND:-"cargo run --release"}
+CARGO_COMMAND=${CARGO_COMMAND:-"cargo run --release --locked"}
Review Comment:
either remove --locked or add a code comment why it should be here
##########
ci/scripts/rust_clippy.sh:
##########
@@ -18,6 +18,4 @@
# under the License.
set -ex
-cargo clippy --all-targets --workspace --features
avro,pyarrow,integration-tests -- -D warnings
-cd datafusion-cli
-cargo clippy --all-targets --all-features -- -D warnings
Review Comment:
Not being able to clippy with `--all-features` is a loss.
I know there are few mutually-excluding features (sigh), but we can do
better than clippying 3 features and not clippying all the rest.
Let's follow-up on this.
In a follow-up we should also clippy (or check) with no-default-features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
