findepi commented on PR #14483: URL: https://github.com/apache/datafusion/pull/14483#issuecomment-2636298157
@mbrobbel many changes in this PR are about adding `--locked` to various cargo invocations. I think it should be possible to verify dependencies in one place, and then keep eg running `cargo test` without `--locked`. The benefit would be not only smaller PR diff, but also easier to comprehend cargo incantation on CI (when a build fails, the command line matters). If, however, it's necessary to have `--locked` in cargo test, then i would recommend adding a code comment explaining why it's so. It's not obvious, at least to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
