findepi commented on code in PR #14483: URL: https://github.com/apache/datafusion/pull/14483#discussion_r1942615130
########## ci/scripts/rust_clippy.sh: ########## @@ -18,6 +18,4 @@ # under the License. set -ex -cargo clippy --all-targets --workspace --features avro,pyarrow,integration-tests -- -D warnings -cd datafusion-cli -cargo clippy --all-targets --all-features -- -D warnings Review Comment: i think all-features may be problematic for core, not benchmarks. but if the abve works, great! let's do this in a follow-up though. let's focus on getting cargo.lock into the repo, and do non-mandatory clippy improvement on its own focused pr (PR review time is non-linear of its size) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
