Omega359 commented on code in PR #14745: URL: https://github.com/apache/datafusion/pull/14745#discussion_r1960319965
########## .github/workflows/extended.yml: ########## @@ -39,43 +39,54 @@ jobs: linux-build-lib: name: linux build test runs-on: ubuntu-latest - container: - image: amd64/rust steps: - uses: actions/checkout@v4 - - name: Setup Rust toolchain - uses: ./.github/actions/setup-builder with: - rust-version: stable + submodules: true + fetch-depth: 1 + - name: Install Rust + run: | + curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y + source $HOME/.cargo/env + rustup default stable + - name: Install Protobuf Compiler + run: sudo apt-get install -y protobuf-compiler - name: Prepare cargo build run: | cargo check --profile ci --all-targets cargo clean -# # Run extended tests (with feature 'extended_tests') -# # Disabling as it is running out of disk space -# # see https://github.com/apache/datafusion/issues/14576 -# linux-test-extended: -# name: cargo test 'extended_tests' (amd64) -# needs: linux-build-lib -# runs-on: ubuntu-latest -# container: -# image: amd64/rust -# steps: -# - uses: actions/checkout@v4 -# with: -# submodules: true -# fetch-depth: 1 -# - name: Setup Rust toolchain -# uses: ./.github/actions/setup-builder -# with: -# rust-version: stable -# - name: Run tests (excluding doctests) -# run: cargo test --profile ci --exclude datafusion-examples --exclude datafusion-benchmarks --workspace --lib --tests --bins --features avro,json,backtrace,extended_tests -# - name: Verify Working Directory Clean -# run: git diff --exit-code -# - name: Cleanup -# run: cargo clean + # Run extended tests (with feature 'extended_tests') + linux-test-extended: + name: cargo test 'extended_tests' (amd64) + needs: linux-build-lib + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + with: + submodules: true + fetch-depth: 1 + - name: Free Disk Space (Ubuntu) + uses: jlumbroso/free-disk-space@v1.3.1 Review Comment: This may possibly be a concern - the apache org limits what 3rd party actions are allowed though I am unsure if there is a list of them. I know I've encountered actions that were not allowed in the past. If it is a blocker you may have to request an exemption from the apache devops people. I think they also may want to use a git hash vs a version # to be sure it doesn't change underneath us. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org