Omega359 commented on code in PR #14745:
URL: https://github.com/apache/datafusion/pull/14745#discussion_r1960327104
##########
datafusion/core/tests/memory_limit/memory_limit_validation/sort_mem_validation.rs:
##########
@@ -67,10 +69,35 @@ fn sort_with_mem_limit_2_cols_2_runner() {
spawn_test_process("sort_with_mem_limit_2_cols_2");
}
+/// `spawn_test_process` might trigger multiple recompilation, and the test
binary
+/// size might grow indifinitely. This initilizer ensures recompilation is
only done
+/// once and the target size is bounded.
Review Comment:
```suggestion
/// `spawn_test_process` might trigger multiple recompilations and the test
binary
/// size might grow indefinitely. This initializer ensures recompilation is
only done
/// once and the target size is bounded.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
