ozankabak commented on code in PR #14745:
URL: https://github.com/apache/datafusion/pull/14745#discussion_r1961014910
##########
.github/workflows/extended.yml:
##########
@@ -95,7 +106,7 @@ jobs:
- name: Run tests
run: |
cd datafusion
- cargo test --profile ci --exclude datafusion-examples --exclude
datafusion-benchmarks --exclude datafusion-sqllogictest --workspace --lib
--tests --features=force_hash_collisions,avro,extended_tests
+ cargo test --profile ci --exclude datafusion-examples --exclude
datafusion-benchmarks --exclude datafusion-sqllogictest --workspace --lib
--tests --features=force_hash_collisions,avro
Review Comment:
~Why will we not run extended tests with hash collisions? We may lose some
coverage here. If the only problematic thing is the memory-limited tests, we
should place it under a separate flag and only skip those tests.~
What I wrote above seems wrong - I did a search and the `extended_tests`
seems to be only gating these memory tests. If that is the case, maybe the name
of the flag is not that great -- it led me to think we are disabling a bunch of
other tests in addition to these ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
