findepi commented on code in PR #14689:
URL: https://github.com/apache/datafusion/pull/14689#discussion_r1962985669
##########
datafusion/core/src/execution/context/csv.rs:
##########
@@ -116,11 +116,11 @@ mod tests {
assert_eq!(results.len(), 1);
let expected = [
- "+--------------+--------------+----------+",
- "| sum(test.c1) | sum(test.c2) | count(*) |",
- "+--------------+--------------+----------+",
- "| 10 | 110 | 20 |",
- "+--------------+--------------+----------+",
+ "+--------------+--------------+--------------+",
+ "| sum(test.c1) | sum(test.c2) | count_star() |",
Review Comment:
> It would be great if this could stay `count(*)`
i agree ...
> Perhaps that is why you implemented `AggregateUDFImpl::display_name` 🤔
... but not at any cost.
if displaying `count(*)` rather than (equivalent) `count(1)` requires ~200
lines of duplicated code, i'd stick with `count(1)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
