andygrove commented on PR #1424: URL: https://github.com/apache/datafusion-comet/pull/1424#issuecomment-2674739703
> @andygrove Thanks for opening this PR! I have one questions though. > > I also tried to apply the same build side selection logic but found that with multi executors, the CometExchange that is executed right after CometHashJoin with BuildLeft gets slower as described here [#1382 (comment)](https://github.com/apache/datafusion-comet/issues/1382#issuecomment-2650539273) and that is why I did not open PR. Is it confirmed that queries are faster with multi executors as well? I will test with multiple executors today, just to be sure, but I suspect the issue you were seeing is related to spilling in shuffle. I commented on the issue. I will share the results here later today for multi-executor testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
