andygrove commented on PR #1424: URL: https://github.com/apache/datafusion-comet/pull/1424#issuecomment-2675738118
Thanks for the reviews @comphead @parthchandra @kazuyukitanimura @mbutrovich @hayman42 I ran benchmarks with 1 executor w/ 8 cores vs 2 executors w/ 4 cores and saw no difference in performance, so I will go ahead and merge this PR. I do see issues if shuffle has to spill, and I have ideas on how we can greatly improve this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
