andygrove commented on code in PR #1424:
URL: https://github.com/apache/datafusion-comet/pull/1424#discussion_r1966123689
##########
spark/src/main/scala/org/apache/comet/rules/RewriteJoin.scala:
##########
@@ -48,7 +64,7 @@ object RewriteJoin extends JoinSelectionHelper {
def rewrite(plan: SparkPlan): SparkPlan = plan match {
case smj: SortMergeJoinExec =>
- getBuildSide(smj.joinType) match {
+ getSmjBuildSide(smj) match {
case Some(BuildRight) if smj.joinType == LeftSemi =>
// TODO this was added as a workaround for TPC-DS q14 hanging and
needs
// further investigation
Review Comment:
This is needed both before and after this PR. I think it may be related to
excessive spilling and shuffle but it still needs to be investigated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
