vmingchen commented on code in PR #1195: URL: https://github.com/apache/datafusion-ballista/pull/1195#discussion_r1986085372
########## benchmarks/src/bin/tpch.rs: ########## @@ -1534,6 +1562,86 @@ mod tests { Ok(()) } + // Our queries do not have the LIMIT clause, so we need to apply it + // before comparing the results with the expected results. Review Comment: Make sense. I have reapplied the limit and reverted the normalization-limit step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org