vmingchen commented on code in PR #1195:
URL:
https://github.com/apache/datafusion-ballista/pull/1195#discussion_r1986085830
##########
benchmarks/src/bin/tpch.rs:
##########
@@ -1534,6 +1562,86 @@ mod tests {
Ok(())
}
+ // Our queries do not have the LIMIT clause, so we need to apply it
+ // before comparing the results with the expected results.
Review Comment:
To provide more context, the ":n 100" lines in the official TPCH sql files
are called flags. They are handled by the `qsub` function in qgen.c file:
```c
/*
* FUNCTION qsub(char *qtag, int flags)
*
* based on the settings of flags, and the template file $QDIR/qtag.sql
* make the following substitutions to turn a query template into EQT
*
* String Converted to Based on
* ====== ============ ===========
* first line database <db_name>; -n from command line
* second line set explain on; -x from command line
* :<number> parameter <number>
* :k set number
* :o output to outpath/qnum.snum----
* -o from command line, SET_OUTPUT
* :s stream number
* :b BEGIN WORK; -a from command line, START_TRAN
* :e COMMIT WORK; -a from command line, END_TRAN
* :q query number
* :n<number> sets rowcount to be returned
*/
void
qsub(char *qtag, int flags)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
