Chen-Yuan-Lai commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r1986346839
##########
datafusion/functions/src/crypto/basic.rs:
##########
@@ -342,22 +367,27 @@ pub fn digest_process(
DataType::LargeBinary => {
digest_algorithm.digest_binary_array::<i64>(a.as_ref())
}
- other => exec_err!(
- "Unsupported data type {other:?} for function
{digest_algorithm}"
- ),
- },
- ColumnarValue::Scalar(scalar) => match scalar {
- ScalarValue::Utf8View(a)
- | ScalarValue::Utf8(a)
- | ScalarValue::LargeUtf8(a) => {
- Ok(digest_algorithm
- .digest_scalar(a.as_ref().map(|s: &String| s.as_bytes())))
+ DataType::BinaryView => {
+ digest_algorithm.digest_binary_array::<i32>(a.as_ref())
Review Comment:
I'm not sure if `i32` makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
