Re: [PR] refactor: use TypeSignature::Coercible for crypto functions [datafusion]

[via GitHub]

jayzhan211 commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r1986495558


##########
datafusion/functions/src/crypto/sha512.rs:
##########
@@ -52,11 +56,16 @@ impl Default for SHA512Func {
 
 impl SHA512Func {
     pub fn new() -> Self {
-        use DataType::*;
         Self {
-            signature: Signature::uniform(
-                1,
-                vec![Utf8View, Utf8, LargeUtf8, Binary, LargeBinary],
+            signature: Signature::one_of(
+                vec![
+                    TypeSignature::Coercible(vec![Coercion::new_exact(

Review Comment:
   the return type is `utf8_or_binary_to_binary_type`
   which means the signtaure of sha512 should be new_implicit(binary, 
string|binary)
   
   Target is binary, and allowed source types are string and binary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org