Chen-Yuan-Lai commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r1986347452
##########
datafusion/functions/src/crypto/basic.rs:
##########
@@ -328,6 +322,37 @@ impl DigestAlgorithm {
}
}
}
+
+ pub fn digest_binary_array_impl<'a, BinaryArrType>(
+ self,
+ input_value: BinaryArrType,
+ ) -> ArrayRef
+ where
+ BinaryArrType: BinaryArrayType<'a>,
+ {
+ match self {
+ Self::Md5 => digest_to_array!(Md5, input_value),
+ Self::Sha224 => digest_to_array!(Sha224, input_value),
+ Self::Sha256 => digest_to_array!(Sha256, input_value),
+ Self::Sha384 => digest_to_array!(Sha384, input_value),
+ Self::Sha512 => digest_to_array!(Sha512, input_value),
+ Self::Blake2b => digest_to_array!(Blake2b512, input_value),
+ Self::Blake2s => digest_to_array!(Blake2s256, input_value),
+ Self::Blake3 => {
+ let binary_array: BinaryArray = input_value
+ .iter()
+ .map(|opt| {
+ opt.map(|x| {
+ let mut digest = Blake3::default();
+ digest.update(x);
+ Blake3::finalize(&digest).as_bytes().to_vec()
+ })
+ })
+ .collect();
+ Arc::new(binary_array)
+ }
+ }
+ }
Review Comment:
I found that `digest_binary_array_impl` and `digest_utf8_array_impl` are
similar, should we integrate them into one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
