Blizzara opened a new pull request, #15211: URL: https://github.com/apache/datafusion/pull/15211
## Which issue does this PR close? Currently duplicate WindowFunction calls would fail due to duplicate unqualified name. ## Rationale for this change ## What changes are included in this PR? De-duplicate WindowFunction expressions before creating a window node to wrap them. This also optimizes the window wrapping to only do it once per unique Window, with all provided WindowFunctions, rather than creating one window rel per function. ## Are these changes tested? Added two new tests Substrait JSON tests, since DF itself wouldn't normally produce these plans (the DF optimizer handles deduplication and separating the distinct windows. ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
