Blizzara commented on code in PR #15211:
URL: https://github.com/apache/datafusion/pull/15211#discussion_r1994161768
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1083,18 +1086,24 @@ pub async fn from_project_rel(
// Adding the same expression here and in the project below
// works because the project's builder uses columnize_expr(..)
// to transform it into a column reference
- input = input.window(vec![e.clone()])?
+ window_exprs.insert(e.clone());
}
explicit_exprs.push(name_tracker.get_uniquely_named_expr(e)?);
}
+ let input = if !window_exprs.is_empty() {
+ LogicalPlanBuilder::window_plan(input, window_exprs)?
Review Comment:
This has logic built in to separate the expressions by their windows, so
it's kinda nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
