Blizzara commented on code in PR #15211: URL: https://github.com/apache/datafusion/pull/15211#discussion_r1993981839
########## datafusion/expr/src/logical_plan/builder.rs: ########## @@ -486,7 +486,7 @@ impl LogicalPlanBuilder { /// Wrap a plan in a window pub fn window_plan( input: LogicalPlan, - window_exprs: Vec<Expr>, + window_exprs: impl IntoIterator<Item = Expr>, Review Comment: this allows feeding in a HashSet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org