gabotechs commented on code in PR #15345:
URL: https://github.com/apache/datafusion/pull/15345#discussion_r2007244821
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1975,6 +1975,13 @@ pub async fn from_substrait_agg_func(
let args = from_substrait_func_args(consumer, &f.arguments,
input_schema).await?;
+ // deal with situation that count(*) got no arguments
Review Comment:
pretty much just rolled back whatever was removed in
https://github.com/apache/datafusion/pull/14824, I would like some input first
from @jayzhan211 about why was this removed and if it might be breaking
something else that the tests are not catching
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
