jayzhan211 commented on code in PR #15345:
URL: https://github.com/apache/datafusion/pull/15345#discussion_r2007610582
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1975,6 +1975,13 @@ pub async fn from_substrait_agg_func(
let args = from_substrait_func_args(consumer, &f.arguments,
input_schema).await?;
+ // deal with situation that count(*) got no arguments
Review Comment:
I remove it because I don't why we need to convert `count()` to `count(1)`,
is there any reason we need `count(1)` in subtrait?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
