andygrove commented on code in PR #1559:
URL: https://github.com/apache/datafusion-comet/pull/1559#discussion_r2008004761
##########
spark/src/test/scala/org/apache/spark/sql/CometTPCDSQueryTestSuite.scala:
##########
@@ -213,7 +221,7 @@ class CometTPCDSQueryTestSuite extends QueryTest with
TPCDSBase with CometSQLQue
// that can cause OOM in GitHub Actions
if (!(sortMergeJoin && name == "q72")) {
System.gc() // Workaround for GitHub Actions memory limitation,
see also SPARK-37368
- runQuery(queryString, goldenFile, conf)
+ runQuery(queryString, goldenFile, baseConf ++ conf)
Review Comment:
> Should we add `baseConf` to `joinConfs` so that all confs get the
`baseConf`?
That is what I initially tried, but that would also have required updates to
CI scripts (`benchmark.yml`) because there has to be an exact match to the
configs defined there, such as:
```
SPARK_TPCDS_JOIN_CONF: |
spark.sql.autoBroadcastJoinThreshold=-1
spark.sql.join.preferSortMergeJoin=true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
