andygrove commented on code in PR #1559:
URL: https://github.com/apache/datafusion-comet/pull/1559#discussion_r2006508189
##########
spark/src/test/scala/org/apache/spark/sql/CometTPCHQuerySuite.scala:
##########
@@ -90,10 +90,8 @@ class CometTPCHQuerySuite extends QueryTest with TPCBase
with ShimCometTPCHQuery
conf.set(CometConf.COMET_EXEC_ENABLED.key, "true")
conf.set(CometConf.COMET_NATIVE_SCAN_ENABLED.key, "true")
conf.set(CometConf.COMET_EXEC_SHUFFLE_ENABLED.key, "true")
- conf.set(CometConf.COMET_SHUFFLE_MODE.key, "jvm")
conf.set(MEMORY_OFFHEAP_ENABLED.key, "true")
conf.set(MEMORY_OFFHEAP_SIZE.key, "2g")
- conf.set(CometConf.COMET_MEMORY_OVERHEAD.key, "2g")
Review Comment:
`COMET_MEMORY_OVERHEAD` is not used in off-heap mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
