goldmedal commented on code in PR #15334:
URL: https://github.com/apache/datafusion/pull/15334#discussion_r2008714660
##########
datafusion/sqllogictest/test_files/tpch/plans/q22.slt.part:
##########
@@ -65,7 +65,7 @@ logical_plan
07)------------Projection: customer.c_phone, customer.c_acctbal
08)--------------LeftAnti Join: customer.c_custkey =
__correlated_sq_1.o_custkey
09)----------------Filter: substr(customer.c_phone, Int64(1), Int64(2)) IN
([Utf8View("13"), Utf8View("31"), Utf8View("23"), Utf8View("29"),
Utf8View("30"), Utf8View("18"), Utf8View("17")])
-10)------------------TableScan: customer projection=[c_custkey, c_phone,
c_acctbal], partial_filters=[substr(customer.c_phone, Int64(1), Int64(2)) IN
([Utf8View("13"), Utf8View("31"), Utf8View("23"), Utf8View("29"),
Utf8View("30"), Utf8View("18"), Utf8View("17")])]
+10)------------------TableScan: customer projection=[c_custkey, c_phone,
c_acctbal], partial_filters=[substr(customer.c_phone, Int64(1), Int64(2)) IN
([Utf8View("13"), Utf8View("31"), Utf8View("23"), Utf8View("29"),
Utf8View("30"), Utf8View("18"), Utf8View("17")]), Boolean(true)]
Review Comment:
I benchmarked to ensure the plan change won't impact the performance.
```
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query ┃ main ┃ fix_join-check ┃ Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1 │ 68.97ms │ 70.14ms │ no change │
│ QQuery 2 │ 18.72ms │ 18.55ms │ no change │
│ QQuery 3 │ 30.47ms │ 29.46ms │ no change │
│ QQuery 4 │ 21.45ms │ 21.77ms │ no change │
│ QQuery 5 │ 43.53ms │ 41.56ms │ no change │
│ QQuery 6 │ 14.39ms │ 14.88ms │ no change │
│ QQuery 7 │ 55.03ms │ 55.30ms │ no change │
│ QQuery 8 │ 41.24ms │ 39.45ms │ no change │
│ QQuery 9 │ 50.84ms │ 53.19ms │ no change │
│ QQuery 10 │ 44.85ms │ 44.83ms │ no change │
│ QQuery 11 │ 13.42ms │ 13.22ms │ no change │
│ QQuery 12 │ 28.49ms │ 28.20ms │ no change │
│ QQuery 13 │ 29.56ms │ 29.38ms │ no change │
│ QQuery 14 │ 23.03ms │ 24.40ms │ 1.06x slower │
│ QQuery 15 │ 33.59ms │ 34.98ms │ no change │
│ QQuery 16 │ 13.07ms │ 13.08ms │ no change │
│ QQuery 17 │ 58.00ms │ 58.67ms │ no change │
│ QQuery 18 │ 76.00ms │ 75.06ms │ no change │
│ QQuery 19 │ 39.99ms │ 38.40ms │ no change │
│ QQuery 20 │ 29.04ms │ 29.79ms │ no change │
│ QQuery 21 │ 62.14ms │ 64.14ms │ no change │
│ QQuery 22 │ 13.82ms │ 14.01ms │ no change │
└──────────────┴─────────┴────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩
│ Total Time (main) │ 809.65ms │
│ Total Time (fix_join-check) │ 812.45ms │
│ Average Time (main) │ 36.80ms │
│ Average Time (fix_join-check) │ 36.93ms │
│ Queries Faster │ 0 │
│ Queries Slower │ 1 │
│ Queries with No Change │ 21 │
└───────────────────────────────┴──────────┘
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
