alamb commented on PR #15301: URL: https://github.com/apache/datafusion/pull/15301#issuecomment-2759408768
> What would the advantages of doing this with a PhysExpr be? The main one I can think of is avoiding introducing the new DynamicFilterSource trait. I guess I was thinking that if it was a PhysicalExpr then it could immediately be used everywhere that a phsyical expression can be (e.g. parquet pushdown filters, join conditions, FilterExec, etc) It seems to me like adding a DynamicFilterSource means we now have to have multiple types of filters that each operator needs to know about -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
