adriangb commented on PR #15301: URL: https://github.com/apache/datafusion/pull/15301#issuecomment-2759576175
Hmm interesting about the join conditions. I have not thought about how this will interact with a join in the same query. Another concern with a dynamic physicalexpr: more lock contention. Presumably every time it's evaluated (for each row?) we need to acquire a lock to read from the TopK heap. And for using an optimizer rule: would that be compatible with custom ExecutionPlans? As this is currently implemented it's possible for a custom execution plan to accept and/or forward the dynamic filters downstream. Could I implement eg a CachedParquetExec that could have the dynamic filters pushed down via an optimizer rule? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
