suibianwanwank commented on PR #15301: URL: https://github.com/apache/datafusion/pull/15301#issuecomment-2760078487
> Another concern with a dynamic physicalexpr: more lock contention. Presumably every time it's evaluated (for each row?) we need to acquire a lock to read from the TopK heap. I also suspect this—it might actually degrade query performance. That said, I still think a `dynamic physicalexpr` is a great idea as it allows for more flexibility. For scenarios like join conditions, perhaps we can balance this by controlling the frequency of writes to the predicate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
