adriangb commented on code in PR #15566: URL: https://github.com/apache/datafusion/pull/15566#discussion_r2036084527
########## datafusion/expr/src/filter_pushdown.rs: ########## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +/// Result of attempting to push down a filter/predicate expression. +/// +/// This is used by: +/// * `FilterPushdownResult` in `ExecutionPlan` to do predicate pushdown at the physical plan level +/// (e.g. pushing down dynamic fitlers from a hash join into scans). +/// * `TableProvider` to do predicate pushdown at planning time (e.g. pruning partitions). +/// +/// There are three possible outcomes of a filter pushdown: +/// * [`FilterPushdown::Unsupported`] - the filter could not be applied / is not understood. +/// * [`FilterPushdown::Inexact`] - the filter could be applied, but it may not be exact. Review Comment: Makes sense. The variants were chosen to match the existing `TableProviderFilterPushdown`, which @alamb requested specifically. IMO we could have 2 variants here: `Unsupported` and `Exact` and it would be clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
