changsun20 commented on PR #15696:
URL: https://github.com/apache/datafusion/pull/15696#issuecomment-2799781696
Hi @eliaperantoni,
Thank you for your patience and guidance throughout this issue. I've
implemented the core functionality per our discussions, but would like to
confirm a few implementation details:
1. **Predicate Context Validation**
The warning detection is integrated during `BinaryExpr` processing,
which should naturally limit it to predicate contexts. Statements like `UPDATE
users SET password = NULL` won't trigger false warnings by default. Could you
confirm this approach is acceptable?
2. **Span Handling Strategy**
In usual cases, the left operand is an `Identifier`. The current
implementation combines the identifier's left span with NULL's right span for
precise highlighting. For rare non-identifier cases (e.g., some complex
expressions that I can't immediately come up with one right now), we fall back
to using just the NULL span. This balances precision with robustness.
3. **Test Coverage Request**
While I've added tests for basic and multiple `= NULL` cases, could you
suggest any edge cases or additional scenarios that should be validated?
I appreciate your expertise in reviewing these implementation choices.
Please let me know if any adjustments are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
