alamb commented on PR #1815: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1815#issuecomment-2813825103
> oops , I forgot to mention the tests. I found it will be covered by the original case: I was thinking a test that would prevent against regressions in a future refactor -- namely a test that will fail if this code change is reverted, I think as it stands, if the code change is reverted all the tests will still pass 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
