goldmedal commented on code in PR #1815:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1815#discussion_r2050635516
##########
tests/sqlparser_common.rs:
##########
@@ -11642,16 +11642,28 @@ fn parse_connect_by() {
#[test]
fn test_selective_aggregation() {
+ let testing_dialects = all_dialects_where(|d|
d.supports_filter_during_aggregation());
+ let expected_dialects: Vec<Box<dyn Dialect>> = vec![
+ Box::new(PostgreSqlDialect {}),
+ Box::new(DatabricksDialect {}),
+ Box::new(HiveDialect {}),
+ Box::new(SQLiteDialect {}),
+ Box::new(DuckDbDialect {}),
+ Box::new(GenericDialect {}),
+ ];
+ assert_eq!(testing_dialects.dialects.len(), expected_dialects.len());
+ expected_dialects
+ .into_iter()
+ .for_each(|d| assert!(d.supports_filter_during_aggregation()));
Review Comment:
I list all the dialects expected to support filtering during aggregation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
