goldmedal commented on PR #1815: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1815#issuecomment-2814306305
> > oops , I forgot to mention the tests. I found it will be covered by the original case: > > I was thinking a test that would prevent against regressions in a future refactor -- namely a test that will fail if this code change is reverted, > > I think as it stands, if the code change is reverted all the tests will still pass 🤔 I see. Make sense. I'll add another test to protect it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
