andygrove commented on code in PR #1655:
URL: https://github.com/apache/datafusion-comet/pull/1655#discussion_r2051083077
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2889,6 +2878,35 @@ object QueryPlanSerde extends Logging with CometExprShim
{
}
}
+ /**
+ * Determine which data types are supported in a shuffle.
+ */
+ def supportedShuffleDataType(dt: DataType): Boolean = dt match {
+ case _: BooleanType => true
Review Comment:
No. At one point I was seeing errors related to boolean and had made
functional changes here that I later reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
