comphead commented on code in PR #1655: URL: https://github.com/apache/datafusion-comet/pull/1655#discussion_r2049450280
########## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ########## @@ -2889,6 +2857,48 @@ object QueryPlanSerde extends Logging with CometExprShim { } } + /** + * Determine which data types are supported as hash-partition keys in a shuffle. + */ + def supportedShufflePartitionDataType(dt: DataType): Boolean = dt match { Review Comment: ```suggestion def supportedShufflePartitionKeyDataType(dt: DataType): Boolean = dt match { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org