kazuyukitanimura commented on code in PR #1655:
URL: https://github.com/apache/datafusion-comet/pull/1655#discussion_r2051045028
##########
spark/src/test/scala/org/apache/comet/CometFuzzTestSuite.scala:
##########
@@ -161,6 +162,18 @@ class CometFuzzTestSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("shuffle") {
+ val df = spark.read.parquet(filename)
Review Comment:
Does the data have complex type?
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2889,6 +2878,35 @@ object QueryPlanSerde extends Logging with CometExprShim
{
}
}
+ /**
+ * Determine which data types are supported in a shuffle.
+ */
+ def supportedShuffleDataType(dt: DataType): Boolean = dt match {
+ case _: BooleanType => true
Review Comment:
nit : BooleanType moved here alone because of the code style checks?
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2889,6 +2855,31 @@ object QueryPlanSerde extends Logging with CometExprShim
{
}
}
+ def supportedShuffleDataType(dt: DataType): Boolean = dt match {
+ case _: ByteType | _: ShortType | _: IntegerType | _: LongType | _:
FloatType |
+ _: DoubleType | _: StringType | _: BinaryType | _: TimestampType | _:
TimestampNTZType |
Review Comment:
Do we have a test with TimestampNTZType for shuffle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
