hsiang-c opened a new pull request, #1667: URL: https://github.com/apache/datafusion-comet/pull/1667
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #. https://github.com/apache/datafusion-comet/issues/1612 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Let users know the unsupported field(s) in the schema and the configuration that lead to the warning message. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> - When we detect unsupported schemas / partitioning schemas, report the first unsupported field in the schemas as part of the `fallbackReasons`. - Additionally, shows that `spark.comet.scan.allowIncompatible` is set to false on native scan implementations. ## How are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ### Config 1 ```scala .config("spark.comet.scan.impl", "native_comet") .config("spark.comet.scan.allowIncompatible", "false") ``` ```shell 25/04/18 15:18:23 WARN CometSparkSessionExtensions$CometExecRule: Comet cannot execute some parts of this plan natively (set spark.comet.explainFallback.enabled=false to disable this logging): CollectLimit [COMET: CollectLimit is not supported] +- Project [COMET: Project is not native because the following children are not native (Scan parquet )] +- Scan parquet [COMET: Unsupported field StructField(weight_kg,ArrayType(ShortType,true),true) in schema StructType(StructField(product_id,StringType,true),StructField(product_name,StringType,true),StructField(weight_kg,ArrayType(ShortType,true),true)) for native_comet, Scan parquet is not supported] ``` ### Config 2 ```scala .config("spark.comet.scan.impl", "native_datafusion") .config("spark.comet.scan.allowIncompatible", "false") ``` ```shell 25/04/18 15:19:44 WARN CometSparkSessionExtensions$CometExecRule: Comet cannot execute some parts of this plan natively (set spark.comet.explainFallback.enabled=false to disable this logging): CollectLimit [COMET: CollectLimit is not supported] +- Project [COMET: Project is not native because the following children are not native (Scan parquet )] +- Scan parquet [COMET: Unsupported field StructField(weight_kg,ArrayType(ShortType,true),true) in schema StructType(StructField(product_id,StringType,true),StructField(product_name,StringType,true),StructField(weight_kg,ArrayType(ShortType,true),true)) for native_datafusion, and spark.comet.scan.allowIncompatible is false, Scan parquet is not supported] ``` ### Config 3 ```scala .config("spark.comet.scan.impl", "native_iceberg_compat") .config("spark.comet.scan.allowIncompatible", "false") ``` ```shell 25/04/18 15:20:37 WARN CometSparkSessionExtensions$CometExecRule: Comet cannot execute some parts of this plan natively (set spark.comet.explainFallback.enabled=false to disable this logging): CollectLimit [COMET: CollectLimit is not supported] +- Project [COMET: Project is not native because the following children are not native (Scan parquet )] +- Scan parquet [COMET: Unsupported field StructField(weight_kg,ArrayType(ShortType,true),true) in schema StructType(StructField(product_id,StringType,true),StructField(product_name,StringType,true),StructField(weight_kg,ArrayType(ShortType,true),true)) for native_iceberg_compat, and spark.comet.scan.allowIncompatible is false, Scan parquet is not supported] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
