andygrove commented on code in PR #1667:
URL: https://github.com/apache/datafusion-comet/pull/1667#discussion_r2054367997
##########
spark/src/main/scala/org/apache/comet/DataTypeSupport.scala:
##########
@@ -37,8 +39,7 @@ trait DataTypeSupport {
private def isGloballySupported(dt: DataType): Boolean = dt match {
case ByteType | ShortType
- if CometSparkSessionExtensions.usingDataFusionParquetExec(SQLConf.get)
&&
- !CometConf.COMET_SCAN_ALLOW_INCOMPATIBLE.get() =>
+ if
usingParquetExecWithIncompatTypes(CometConf.COMET_NATIVE_SCAN_IMPL.get(SQLConf.get))
=>
Review Comment:
This config could change during the Spark session lifetime (we often change
it during tests, for example)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
