EmilyMatt opened a new pull request, #1677:
URL: https://github.com/apache/datafusion-comet/pull/1677
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Reduce the amount of duplicate crates due to crates that use outdated
versions, thereby improving compile times and reducing binary size.
Some of the crates(such as rand) have also made changes due to upcoming Rust
Compiler changes that would give them compilation errors(reserved keywords, in
this case, I believe)
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Update crate versions, removed some unused crates, removed crate versions
when using "path"(for less maintenance), and moved to use the crates.io version
of datafusion now that its released(it was left on the git version)
For the rand crate, updated the usage based on the deprecation warnings.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Firstly by compilation, then all the tests passing normally should be enough.
As for timing and crate count:
branch `main`
Binary size - 75MBs (release build)
branch `update-crates`
Binary size - 73MBs(release build)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
