andygrove commented on code in PR #1677:
URL: https://github.com/apache/datafusion-comet/pull/1677#discussion_r2056028940
##########
native/Cargo.toml:
##########
@@ -38,16 +38,16 @@ arrow = { version = "55.0.0", features = ["prettyprint",
"ffi", "chrono-tz"] }
async-trait = { version = "0.1" }
bytes = { version = "1.10.0" }
parquet = { version = "55.0.0", default-features = false, features =
["experimental"] }
-datafusion = { git = "https://github.com/apache/datafusion";, rev = "47.0.0",
default-features = false, features = ["unicode_expressions",
"crypto_expressions", "nested_expressions", "parquet"] }
-datafusion-comet-spark-expr = { path = "spark-expr", version = "0.8.0" }
-datafusion-comet-proto = { path = "proto", version = "0.8.0" }
Review Comment:
It is usally necessary to keep the versions as well otherwise `cargo
publish` will fail. However, we do not publish this crate so it is probably
fine to remove them.
##########
native/Cargo.toml:
##########
@@ -38,16 +38,16 @@ arrow = { version = "55.0.0", features = ["prettyprint",
"ffi", "chrono-tz"] }
async-trait = { version = "0.1" }
bytes = { version = "1.10.0" }
parquet = { version = "55.0.0", default-features = false, features =
["experimental"] }
-datafusion = { git = "https://github.com/apache/datafusion";, rev = "47.0.0",
default-features = false, features = ["unicode_expressions",
"crypto_expressions", "nested_expressions", "parquet"] }
-datafusion-comet-spark-expr = { path = "spark-expr", version = "0.8.0" }
-datafusion-comet-proto = { path = "proto", version = "0.8.0" }
Review Comment:
It is usually necessary to keep the versions as well otherwise `cargo
publish` will fail. However, we do not publish this crate so it is probably
fine to remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
