EmilyMatt commented on code in PR #1677:
URL: https://github.com/apache/datafusion-comet/pull/1677#discussion_r2056074078
##########
.github/workflows/miri.yml:
##########
@@ -38,6 +38,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
+ - name: Install Build Dependencies
+ shell: bash
+ run: |
+ apt-get update
+ apt-get install -y protobuf-compiler
Review Comment:
Previous version of prost carried a fallback binary in case protoc was not
found, but I think its both better to not download a binary executable with a
crate, as well as ensure the miri tests use the same exact code as the regular
build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
